Re: [PATCH v4 2/7] watchdog: mediatek: Add wdt/toprgu resets for mt6589
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-08-27 09:37:10
Also in:
linux-devicetree, linux-mediatek, linux-watchdog, lkml
On Wed, Aug 19, 2026 at 12:16:23PM +0200, Luca Leonardo Scorcia wrote:
quoted hunk ↗ jump to hunk
According to Android sources, mt6589 has 12 reset bits in the WDT_SWSYSRST register. Populate toprgu_sw_rst_num to allow toprgu resets in device trees of the many compatible devices. Signed-off-by: Luca Leonardo Scorcia <redacted> --- drivers/watchdog/mtk_wdt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c index 91d110646e16..f8208fb0f723 100644 --- a/drivers/watchdog/mtk_wdt.c +++ b/drivers/watchdog/mtk_wdt.c@@ -10,6 +10,7 @@ */ #include <dt-bindings/reset/mt2712-resets.h> +#include <dt-bindings/reset/mediatek,mt6589-wdt.h>
I do not see how you use the bindings here, so my previous comments stay. You just ignored it and never replied. In such case: NAK Best regards, Krzysztof