Thread (48 messages) 48 messages, 6 authors, 2026-04-10

Re: [PATCH v2 3/7] iommu: Add iommu_report_device_broken() to quarantine a broken device

From: Nicolin Chen <hidden>
Date: 2026-03-18 20:30:20
Also in: linux-acpi, linux-iommu, linux-pci, lkml

On Wed, Mar 18, 2026 at 07:45:19PM +0800, Shuai Xue wrote:
On 3/18/26 3:15 AM, Nicolin Chen wrote:
quoted
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 9ba12b2164724..9b5f94e566ff9 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -891,6 +891,8 @@ static inline struct iommu_device *__iommu_get_iommu_dev(struct device *dev)
  #define iommu_get_iommu_dev(dev, type, member) \
  	container_of(__iommu_get_iommu_dev(dev), type, member)
+void iommu_report_device_broken(struct device *dev);
+
This declaration is inside the #ifdef CONFIG_IOMMU_API section, but
there's no corresponding stub in the #else block. While current
callers (arm-smmu-v3) always have CONFIG_IOMMU_API, for API
completeness, please add a stub.
Yes. That's a miss.

Thanks
Nicolin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help