Thread (25 messages) 25 messages, 6 authors, 2026-03-12

Re: [PATCH v11 2/3] drm/bridge: imx: Add i.MX93 parallel display format configuration support

From: Liu Ying <victor.liu@nxp.com>
Date: 2026-03-10 02:56:25
Also in: dri-devel, imx, linux-devicetree, lkml

Hi Marco, Luca,

On Tue, Mar 03, 2026 at 11:34:27AM +0100, Marco Felsch wrote:

[...]
+	next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
+	if (IS_ERR(next_bridge))
+		return dev_err_probe(dev, PTR_ERR(next_bridge),
+				     "failed to get next bridge\n");
+	pdfc->dev = dev;
+	pdfc->bridge.of_node = dev->of_node;
+	pdfc->bridge.type = DRM_MODE_CONNECTOR_DPI;
+	pdfc->bridge.next_bridge = next_bridge;
When I was reviewing another patch[1], I was aware of the necessity of
calling drm_bridge_get() for next_bridge to balance the next bridge's
refcount put from __drm_bridge_free() for this bridge.  I'd be good if
Luca may confirm this is correct.  Sorry for bringing this up late.

[1] https://lore.kernel.org/all/5edd40f3-f83e-4a1b-99d4-1e595fc0e4cb@nxp.com/ (local)

-- 
Regards,
Liu Ying
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help