Thread (25 messages) 25 messages, 6 authors, 2026-03-12

Re: [PATCH v11 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example

From: Frank Li <Frank.li@nxp.com>
Date: 2026-03-04 17:04:21
Also in: dri-devel, imx, linux-devicetree, lkml

On Wed, Mar 04, 2026 at 04:49:27PM +0100, Krzysztof Kozlowski wrote:
On 03/03/2026 22:00, Frank Li wrote:
quoted
From: Frank Li (AI-BOT) <frank.li@nxp.com>

AI bot review and may be useless.

This is a device tree bindings patch, not kernel C code. The YAML
schema additions look structurally sound. A few observations:
quoted
+  dpi-bridge:
+    type: object
+    additionalProperties: false
+
+    properties:
+      compatible:
+        enum:
+          - nxp,imx91-pdfc
+          - nxp,imx93-pdfc
The compatible strings should be documented in a separate vendor
prefix file (nxp.yaml) if not already present. Verify they exist
in Documentation/devicetree/bindings/vendor-prefixes.yaml.
What?!?!?

This is nonsense.

Also, you are responding to an already reviewed patch.
Sorry, I tested 22 patches of from imx and sent out intermediate result.

Frank
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help