Re: [RFC PATCH 2/2] arm64: dts: imx8mp-frdm: Use symbolic macros for IOMUXC_SW_PAD_CTL_PAD
From: Frank Li <Frank.li@nxp.com>
Date: 2026-02-27 15:09:15
Also in:
imx, linux-devicetree, lkml
On Fri, Feb 27, 2026 at 03:02:42PM +0200, Daniel Baluta wrote:
Currently, in order to configure IOMUXC_SW_PAD_CTL_PAD a magic raw value is written in this register. This makes code not obvious to read and modify. So, to help with code readability instead of the magic values use symbolic macros.
Use symbolic macros instead of the magic values to improve code readability.
quoted hunk ↗ jump to hunk
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mp-frdm.dts | 132 +++++++++++------- .../arm64/boot/dts/freescale/imx8mp-pinfunc.h | 2 + 2 files changed, 86 insertions(+), 48 deletions(-)diff --git a/arch/arm64/boot/dts/freescale/imx8mp-frdm.dts b/arch/arm64/boot/dts/freescale/imx8mp-frdm.dts index 55690f5e53d7e..206c8d939796e 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-frdm.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-frdm.dts@@ -252,104 +252,140 @@ &usdhc3 {
...
quoted hunk ↗ jump to hunk
>; }; };diff --git a/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h b/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h index 26e7a9428c4c7..c963913e3c626 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h +++ b/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h@@ -38,6 +38,8 @@ MX8MP_HYS_SCHMITT | MX8MP_PULL_ENABLE) #define MX8MP_I2C_DEFAULT (MX8MP_PULL_UP | MX8MP_HYS_SCHMITT | \ MX8MP_PULL_ENABLE | MX8MP_SION) +#define MX8MP_NAND_DATA_DEFAULT (MX8MP_FSEL_FAST | MX8MP_PULL_UP | \ + MX8MP_HYS_SCHMITT | MX8MP_PULL_ENABLE)
It is not NAND, should be MX8MP_USDHC_DATA_DEFAULT Frank
/* * The pin function ID is a tuple of -- 2.45.2