Thread (10 messages) 10 messages, 4 authors, 2026-02-23

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: 2026-02-23 18:08:19
Also in: linux-devicetree, linux-rockchip, lkml

Hi,

Le lundi 23 février 2026 à 19:07 +0200, Cristian Ciocaltea a écrit :
quoted hunk ↗ jump to hunk
On 2/23/26 4:39 PM, Diederik de Haas wrote:
quoted
On Mon Feb 23, 2026 at 3:31 PM CET, Sebastian Reichel wrote:
quoted
On Mon, Feb 23, 2026 at 02:25:05PM +0200, Cristian Ciocaltea wrote:
quoted
When building device trees for the RK3576 based boards, DTC shows the
following complaint:

  rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg):
/soc/video-codec@27b00000: simple-bus unit address format error,
expected "27b00100"

Provide the register blocks in the expected address-based order.

Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video
Decoder on rk3576")
Signed-off-by: Cristian Ciocaltea <redacted>
---
This fixes this warning, but instead creates a new one, because the
reg-names order is fixed in the DT binding:

   reg:
     minItems: 1
     items:
       - description: The function configuration registers base
       - description: The link table configuration registers base
       - description: The cache configuration registers base
  
   reg-names:
     items:
       - const: function
       - const: link
       - const: cache
Oh, right, missed to check the binding.. :-(
quoted
See also the prior discussion wrt this:
https://lore.kernel.org/linux-rockchip/edabca63-594e-44ae-8a3d-0f60987a8664@collabora.com/ (local)
That's interesting, I'm also not able to trigger the warning on RK3588.

Regardless, the binding can be easily adjusted with the patch below.  Hence
I'm
going to handle this in v2, unless there's a reason against moving further.

Thanks,
Cristian

--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -34,10 +34,12 @@ properties:
       - description: The cache configuration registers base

   reg-names:
-    items:
+    oneOf:
Is there a better keyword for that, cause picking 3 of a one of is clearly
confusing to read.

Nicolas
       - const: function
-      - const: link
-      - const: cache
+      - items:
+          - const: link
+          - const: function
+          - const: cache

   interrupts:
     maxItems: 1

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help