Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: 2026-02-23 14:52:01
Also in:
linux-devicetree, linux-rockchip, lkml
Hi Cristian, Le lundi 23 février 2026 à 14:25 +0200, Cristian Ciocaltea a écrit :
quoted hunk ↗ jump to hunk
When building device trees for the RK3576 based boards, DTC shows the following complaint: rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100" Provide the register blocks in the expected address-based order. Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576") Signed-off-by: Cristian Ciocaltea <redacted> --- arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsib/arch/arm64/boot/dts/rockchip/rk3576.dtsi index 49ccdf12ef7e..45eb0d053a6f 100644--- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi@@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {vdec: video-codec@27b00000 { compatible = "rockchip,rk3576-vdec"; - reg = <0x0 0x27b00100 0x0 0x500>, - <0x0 0x27b00000 0x0 0x100>, + reg = <0x0 0x27b00000 0x0 0x100>, + <0x0 0x27b00100 0x0 0x500>, <0x0 0x27b00600 0x0 0x100>; - reg-names = "function", "link", "cache"; + reg-names = "link", "function", "cache";
I have a vague memory it was done on purpose, due to the "items" in the bindings requiring to follow the same order. I was not enable to run the DT checks today (some pythonic version miss-match issue), but wanted to raise the flag. Nicolas
interrupts = <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cru ACLK_RKVDEC_ROOT>, <&cru HCLK_RKVDEC>, <&cru ACLK_RKVDEC_ROOT_BAK>, <&cru CLK_RKVDEC_CORE>, --- base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98
Attachments
- signature.asc [application/pgp-signature] 228 bytes