Re: [PATCH 2/6] media: synopsys: only check errors from devm_clk_bulk_get_all()
From: Michael Riesch <michael.riesch@collabora.com>
Date: 2026-02-13 09:35:20
Also in:
imx, linux-devicetree, linux-media, linux-rockchip, lkml
Hi Frank, Thanks for your patch. The remark w.r.t. the "media: synopsys: csi2rx: " prefix holds for this and all the other patches in this series as well, of course. On 2/10/26 18:11, Frank Li wrote:
quoted hunk ↗ jump to hunk
devm_clk_bulk_get_all() returns all clocks described in the DT, which are already validated by the binding. Do not need enforce an expected clock count. Only check for error returns (< 0) to support more SoCs. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- drivers/media/platform/synopsys/dw-mipi-csi2rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c index 0cc892f4a1b3c6ce575a5d4fca7acf7057f7b7f7..61cd7f491b3d5b8a37707b23ca03ce709b40a79f 100644 --- a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c +++ b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c@@ -630,7 +630,7 @@ static int dw_mipi_csi2rx_probe(struct platform_device *pdev) return PTR_ERR(csi2->base_addr); ret = devm_clk_bulk_get_all(dev, &csi2->clks); - if (ret != DW_MIPI_CSI2RX_CLKS_MAX)
DW_MIPI_CSI2RX_CLKS_MAX is not used anymore, please remove. With that change, Reviewed-by: Michael Riesch <michael.riesch@collabora.com> Best regards, Michael
+ if (ret < 0) return dev_err_probe(dev, -ENODEV, "failed to get clocks\n"); csi2->clks_num = ret;