Hi Krzysztof:

Thanks for your comments

EXTERNAL EMAIL

On 09/02/2026 10:33, Gary Yang wrote:

quoted

+static int sky1_system_control_probe(struct platform_device *pdev) {
+     struct device *dev = &pdev->dev;
+     const struct mfd_cell *cell =
+                     (struct mfd_cell
+*)of_device_get_match_data(dev);
+
+     return mfd_add_devices(dev, PLATFORM_DEVID_NONE, cell, 1, NULL,
+0, NULL); }
+
+static const struct of_device_id sky1_system_control_of_match[] = {
+     { .compatible = "cix,sky1-system-control",
+       .data = sky1_system_control_devs},
+     { .compatible = "cix,sky1-s5-system-control",
+       .data = sky1_s5_system_control_devs},
+     {},
+};
+MODULE_DEVICE_TABLE(of, sky1_system_control_of_match);
+
+static struct platform_driver sky1_system_control_driver = {
+     .driver = {
+             .name = "sky1-system-control",
+             .of_match_table = sky1_system_control_of_match,
+     },
+     .probe = sky1_system_control_probe,

I do not understand why do you need thish driver in the first place.
It's completely empty - just spawns reset driver, so you only need a reset driver.

Layers of indirection are never helpful.

OK, we will remove this file next version. Thanks for your advices

Best Regards
Gary

Best regards,
Krzysztof