Thread (15 messages) 15 messages, 3 authors, 2026-02-20

Re: [PATCH v8 2/3] reset: add Sky1 soc reset support

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-02-09 11:35:31
Also in: linux-devicetree, lkml

On 09/02/2026 10:33, Gary Yang wrote:
+static int sky1_system_control_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	const struct mfd_cell *cell =
+			(struct mfd_cell *)of_device_get_match_data(dev);
+
+	return mfd_add_devices(dev, PLATFORM_DEVID_NONE, cell, 1, NULL, 0, NULL);
+}
+
+static const struct of_device_id sky1_system_control_of_match[] = {
+	{ .compatible = "cix,sky1-system-control",
+	  .data = sky1_system_control_devs},
+	{ .compatible = "cix,sky1-s5-system-control",
+	  .data = sky1_s5_system_control_devs},
+	{},
+};
+MODULE_DEVICE_TABLE(of, sky1_system_control_of_match);
+
+static struct platform_driver sky1_system_control_driver = {
+	.driver = {
+		.name = "sky1-system-control",
+		.of_match_table = sky1_system_control_of_match,
+	},
+	.probe = sky1_system_control_probe,
I do not understand why do you need thish driver in the first place.
It's completely empty - just spawns reset driver, so you only need a
reset driver.

Layers of indirection are never helpful.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help