Re: [PATCH v2 1/3] dt-bindings: usb: introduce fsl,imx-dwc3
From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2026-02-04 12:36:33
Also in:
imx, linux-devicetree, linux-usb, lkml
On Wed, 04 Feb 2026 19:06:16 +0800, Xu Yang wrote:
The i.MX USB glue and DWC3 core are closely coupled. Describe the i.MX USB block in a single block will bring more benefits than a parent- child relation. The new binding is a copy of fsl,imx8mp-dwc3.yaml with the needed modifications. Add the common compatible string "fsl,imx-dwc3" to indicate that the flattened module should be selected. This compatible is also used by "select" to inform the DeviceTree validator to apply this binding. To avoid redefining all the platform-specific compatibles, "select" is used to tell the DeviceTree validator which binding to use solely on the generic compatible. Mark fsl,imx8mp-dwc3 deprecated, to favor expressing future platforms using the new combined binding. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v2: - reorder compatible property --- .../devicetree/bindings/usb/fsl,imx-dwc3.yaml | 131 +++++++++++++++++++++ .../devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml | 13 ++ 2 files changed, 144 insertions(+)
My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/usb/fsl,imx-dwc3.example.dtb: /example-0/usb@4c100000: failed to match any schema with compatible: ['fsl,imx943-dwc3', 'fsl,imx-dwc3'] /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/fsl,imx-dwc3.example.dtb: usb@4c100000 (fsl,imx943-dwc3): compatible:0: 'fsl,imx943-dwc3' is not one of ['fsl,imx8mp-dwc3', 'fsl,imx94-dwc3', 'fsl,imx95-dwc3'] from schema $id: http://devicetree.org/schemas/usb/fsl,imx-dwc3.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260204-add-flatten-dts-based-dwc3-imx-driver-v2-1-d2c9b5a58c01@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.