Hi Krzysztof:

I'm glad to see your comments.

EXTERNAL EMAIL

On 28/01/2026 10:36, Gary Yang wrote:

quoted

There are two reset controllers on Cix sky1 Soc.
One is located in S0 domain, and the other is located in S0 and S5
domain.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/subm
itting-patches.rst#L597

Yes, we will fix it

quoted

Signed-off-by: Gary Yang <redacted>
Link:
https://lore.kernel.org/r/20251124063235.952136-2-gary.yang@cixtech.co
m
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
---
 .../devicetree/bindings/mfd/syscon.yaml       |   7 +
 .../bindings/reset/cix,sky1-rst.yaml          |  46 +++++
 .../soc/cix/cix,sky1-system-controller.yaml   |  48 +++++
 include/dt-bindings/reset/cix,sky1-rst-fch.h  |  42 +++++
 include/dt-bindings/reset/cix,sky1-rst.h      | 164

++++++++++++++++++

quoted

 5 files changed, 307 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
 create mode 100644
Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.y
aml  create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
 create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml

b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 55efb83b1495..be864a6b8efb 100644

--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml

@@ -170,6 +170,8 @@ properties:
               - cirrus,ep7209-syscon1
               - cirrus,ep7209-syscon2
               - cirrus,ep7209-syscon3
+              - cix,sky1-system-controller
+              - cix,sky1-s5-system-controller
               - cnxt,cx92755-uc
               - freecom,fsg-cs2-system-controller
               - fsl,imx93-aonmix-ns-syscfg @@ -254,6 +256,11 @@

properties:
           - const: microchip,pic64gx-sysreg-scb
           - const: microchip,mpfs-sysreg-scb
           - const: syscon
+      - items:
+          - enum:
+              - cix,sky1-system-controller
+              - cix,sky1-s5-system-controller
+          - const: syscon

Do not create your own style. Cix is not special. There is already an enum for
EVERYONE.

quoted

   reg:
     maxItems: 1

Independent patch. Please do not combine unrelated patches into one.

We will delete all changes as Conor's suggestions

quoted

diff --git a/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml

b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
new file mode 100644
index 000000000000..4323acdc2c45

--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml

@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
+---
+$id: http://devicetree.org/schemas/reset/cix,sky1-rst.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: CIX Sky1 Reset Controller
+
+maintainers:
+  - Gary Yang <gary.yang@cixtech.com>
+
+description: |
+  CIX Sky1 reset controller can be used to reset various set of peripherals.
+  There are two reset controllers, one is located in S0 domain, the
+other
+  is located in S0 and S5 domain.
+
+  See also:
+  - include/dt-bindings/reset/cix,sky1-rst.h
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - cix,sky1-rst
+          - cix,sky1-rst-fch
+
+  '#reset-cells':
+    const: 1

No resources? Then not a dedicated child node, but part of the syscon.
Fold this entire binding into the parent node.

How to fold this binding? Is there any example used to refer? If yes, please tell us.
Thanks

quoted

+
+required:
+  - compatible
+  - '#reset-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    syscon@16000000 {
+      compatible = "cix,sky1-s5-system-controller", "syscon",
+                "simple-mfd";

Mess alignment.

quoted

+      reg = <0x0 0x16000000 0x0 0x1000>;

Does not belong here.

quoted

+      src: reset-controller {
+        compatible = "cix,sky1-rst";
+        #reset-cells = <1>;
+      };

quoted

+    };
diff --git
a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller
.yaml
b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller
.yaml
new file mode 100644
index 000000000000..f6e2776e3f53

--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-contro
+++ ller.yaml

@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
+---
+$id:
+http://devicetree.org/schemas/soc/cix/cix,sky1-system-controller.yaml
+#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cix Sky1 SoC system controller register region
+
+maintainers:
+  - Gary Yang <gary.yang@cixtech.com>
+
+description:
+  An wide assortment of registers of the system controller on Sky1
+SoC,
+  including resets and usb.
+
+allOf:
+  - $ref: /schemas/mfd/syscon.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - contains:

What? No, don't come with random code. There is no single code like this.

quoted

+          - enum:
+              - cix,sky1-system-controller
+              - cix,sky1-s5-system-controller
+          - const: syscon
+          - const: simple-mfd

Huh? You already documented this.

NAK, you are making random changes without any concept.

Read previous feedback. Really carefully.

Best regards,
Krzysztof

Sorry for my mistakes. I don't know how to write binding doc except refer to other bindings.
Is there any training docs? Or Please give us some suggestions.

Best Regards
Gary