Hi Philipp:

Thanks for your comments

-----邮件原件-----
发件人: Philipp Zabel [off-list ref]
发送时间: 2026年1月28日 19:27
收件人: Gary Yang [off-list ref]; lee@kernel.org;
robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; Peter Chen
[off-list ref]
抄送: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; cix-kernel-upstream
[off-list ref]
主题: Re: [PATCH v4 2/3] reset: cix: add support for cix sky1 resets

EXTERNAL EMAIL

CAUTION: Suspicious Email from unusual domain.

On Mi, 2026-01-28 at 17:36 +0800, Gary Yang wrote:

quoted

There are two reset controllers on Cix Sky1 Soc.
One is located in S0 domain, and the other is located in S0 and S5
domain.

Signed-off-by: Gary Yang <redacted>
Link:
https://lore.kernel.org/r/20251124063235.952136-3-gary.yang@cixtech.co
m
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
---
 drivers/reset/Kconfig      |   7 +
 drivers/reset/Makefile     |   1 +
 drivers/reset/reset-sky1.c | 376
+++++++++++++++++++++++++++++++++++++
 3 files changed, 384 insertions(+)
 create mode 100644 drivers/reset/reset-sky1.c

[...]

quoted

diff --git a/drivers/reset/reset-sky1.c b/drivers/reset/reset-sky1.c
new file mode 100644 index 000000000000..92e34b48f041
--- /dev/null
+++ b/drivers/reset/reset-sky1.c

@@ -0,0 +1,376 @@

[...]

quoted

+static const struct regmap_config sky1_src_config[] = {
+     {
+             .reg_bits = 32,
+             .val_bits = 32,
+             .reg_stride = 4,
+             .name = "src",
+     },
+};

This looks unused.

Yes, you're right, we will delete it next patch

Best Regards
Gary

regards
Philipp