Re: [PATCH v3 2/5] i2c: xiic: switch to managed version of mutex_init
From: Abdurrahman Hussain <abdurrahman@nexthop.ai>
Date: 2026-01-23 22:25:08
Also in:
linux-i2c, lkml
On Fri Jan 23, 2026 at 9:36 PM UTC, Andrew Lunn wrote:
On Fri, Jan 23, 2026 at 12:20:54PM -0800, Abdurrahman Hussain wrote:quoted
On Fri Jan 23, 2026 at 7:22 PM UTC, Andrew Lunn wrote:quoted
On Fri, Jan 23, 2026 at 08:02:45AM +0000, Abdurrahman Hussain via B4 Relay wrote:quoted
From: Abdurrahman Hussain <abdurrahman@nexthop.ai> Simplify the error path by switching to a managed version of mutex_init.How does this simplify the error path? You don't remove anything from the error path. AndrewThank you for the feedback. In v4, as suggested by Andy, I introduced managed versions of the pm_runtime_ functions which do simplify the error handling.But this patch is not about pm_runtime_, it is about a mutex. How does this patch make the error path simpler? Please make sure your commit messages are accurate.
You are right. In the case of mutex there was no error path. I should have worded it differently. In v4 pm_runtime changes were added to the same patch, so the wording might actually be correct now.