Re: [PATCH v3 5/5] i2c: xiic: minor cosmetic cleanup
From: Andy Shevchenko <hidden>
Date: 2026-01-23 08:37:53
Also in:
linux-i2c, lkml
On Fri, Jan 23, 2026 at 08:02:48AM +0000, Abdurrahman Hussain via B4 Relay wrote:
Add a temporary dev variable and reuse it instead of referencing pdev->dev everywhere.
...
- pm_runtime_enable(i2c->dev);
+ pm_runtime_enable(dev);
Ah, please also move this to devm_pm_...* in a separate patch or combine it with mutex and explain that this fixes the cleanup ordering and simplifies error handling. -- With Best Regards, Andy Shevchenko