Re: [PATCH] drm/rockchip: vop2: Add mode valid callback for crtc

Hi Andy,

On Tue, 20 Jan 2026 at 11:03, Daniel Stone [off-list ref] wrote:

On Fri, 9 Jan 2026 at 00:59, Andy Yan [off-list ref] wrote:

quoted

Filter the mode that can't output by the crtc.

[...]

+static enum drm_mode_status vop2_crtc_mode_valid(struct drm_crtc *crtc,
+                                                const struct drm_display_mode *mode)
+{
+       struct vop2_video_port *vp = to_vop2_video_port(crtc);
+
+       if (mode->hdisplay > vp->data->max_output.width)
+               return MODE_BAD_HVALUE;

Why not test height as well?

I see the question was answered about 45 minutes ago ... anyway, why
not as a follow-up, change struct vop_rect max_output to just a single
max_width value?

Cheers,
Daniel