Thread (3 messages) 3 messages, 2 authors, 2026-01-20

Re: [PATCH] drm/rockchip: vop2: Add mode valid callback for crtc

From: Daniel Stone <hidden>
Date: 2026-01-20 11:04:10
Also in: dri-devel, linux-rockchip, lkml

Hi Andy,

On Fri, 9 Jan 2026 at 00:59, Andy Yan [off-list ref] wrote:
Filter the mode that can't output by the crtc.

[...]

+static enum drm_mode_status vop2_crtc_mode_valid(struct drm_crtc *crtc,
+                                                const struct drm_display_mode *mode)
+{
+       struct vop2_video_port *vp = to_vop2_video_port(crtc);
+
+       if (mode->hdisplay > vp->data->max_output.width)
+               return MODE_BAD_HVALUE;
Why not test height as well?

Cheers,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help