Re: [PATCH v4 25/25] rm/tilcdc: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR
From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
Date: 2026-01-19 17:58:34
Also in:
dri-devel, linux-devicetree, linux-omap, lkml
On Fri Jan 16, 2026 at 6:02 PM CET, Kory Maincent (TI.com) wrote:
quoted hunk ↗ jump to hunk
Convert the driver to use the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridges. This modernizes the driver by delegating connector creation to the bridge subsystem through drm_bridge_connector_init() instead of manually searching for connectors created by the bridge. The custom tilcdc_encoder_find_connector() function is removed and replaced with the standard drm_bridge_connector infrastructure, which simplifies the code and aligns with current DRM bridge best practices. This change is safe as there are now no in-tree devicetrees that connect tilcdc to bridges which do not support the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com> --- Changes in v4: - Select missing DRM_BRIDGE_CONNECTOR and DRM_DISPLAY_HELPER config dependency in Kconfig --- drivers/gpu/drm/tilcdc/Kconfig | 2 ++ drivers/gpu/drm/tilcdc/tilcdc_encoder.c | 37 ++++++++++++++------------------- 2 files changed, 18 insertions(+), 21 deletions(-)diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig index a36e809f984cd..80f53bdd0ace0 100644 --- a/drivers/gpu/drm/tilcdc/Kconfig +++ b/drivers/gpu/drm/tilcdc/Kconfig@@ -6,9 +6,11 @@ config DRM_TILCDC select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER select DRM_BRIDGE + select DRM_BRIDGE_CONNECTOR select DRM_PANEL_BRIDGE select VIDEOMODE_HELPERS select BACKLIGHT_CLASS_DEVICE + select DRM_DISPLAY_HELPER
It looks more logical to put DRM_DISPLAY_HELPER just before DRM_BRIDGE_CONNECTOR. Other than that this patch is de facto the same as v2 which I had already reviewed, so: Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com