RE: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 2026年1月15日 17:39
To: Bough Chen <haibo.chen@nxp.com>
Cc: Han Xu <han.xu@nxp.com>; Mark Brown <broonie@kernel.org>; Rob
Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor
Dooley [off-list ref]; Shawn Guo [off-list ref]; Sascha
Hauer [off-list ref]; Pengutronix Kernel Team
[off-list ref]; Fabio Estevam [off-list ref];
linux-spi@vger.kernel.org; imx@lists.linux.dev; devicetree@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:

quoted

Document i.MX952 XSPI compatible, which is derived from
i.MX94 XSPI.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml

b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
index

a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13
a32

quoted

65315a16992e 100644

--- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
+++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml

@@ -15,6 +15,10 @@ properties:
     oneOf:
       - enum:
           - nxp,imx94-xspi
+      - items:
+          - enum:
+              - nxp,imx952-xspi
+          - const: nxp,imx94-xspi

You never checked your DTS and broke all existing users. And existing tools
would clearly tell you that if you tried.

Use tools instead of reviewers. Reviewers time is more important, so if you just
disregard it I find it quite disrespectful.

Hi Krzysztof,

I did run dt binding check before I send out this patch.
I list the log in the following, no error report.
Can you help point out where I have to improve?

nxa12937@shlinux89:~/linux-next$ make64 distclean
  CLEAN   Documentation/devicetree/bindings
  CLEAN   scripts/basic
  CLEAN   scripts/dtc
  CLEAN   scripts/kconfig
  CLEAN   include/config include/generated .config
nxa12937@shlinux89:~/linux-next$ make64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/dtc
  CHKDT   ./Documentation/devicetree/bindings
  LINT    ./Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dts
  DTC [C] Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dtb

Regards
Haibo Chen

Best regards,
Krzysztof