Re: [PATCH 3/3] arm64: dts: rockchip: Remove interrupt GPIO for WiFi for the Pinephone Pro
From: Ondřej Jirman <megi@xff.cz>
Date: 2026-01-13 21:22:51
Also in:
linux-devicetree, linux-rockchip, lkml
Hi Rudraksha, On Mon, Jan 12, 2026 at 10:42:26PM -0800, Rudraksha Gupta via B4 Relay wrote:
From: Ondrej Jirman <megi@xff.cz> Wifi is currently unusable if interrupts are defined. Let's remove them so that Wifi networks are actually discoverable. Co-developed-by: Martijn Braam <redacted> Signed-off-by: Martijn Braam <redacted> Co-developed-by: Kamil Trzciński <redacted> Signed-off-by: Kamil Trzciński <redacted>
^^ these lines are incorrect and the patch is not meant for upstreaming, really. I think whether OOB interrupts work or not on PPP may be a function of what FW and firmware config file is used. So eg. in brcmfmac43455-sdio.pine64,pinephone-pro.txt you can have settings like: # OOB IRQ settings -- next 3 "sd" parameters uncommented for OOB IRQ. Edge sensitive interrupt via WL_HOST_WAKE line. #muxenab=0x10 #sd_gpout=0 #sd_oobonly=1 #sd_gpval=1 That affect OOB interrupt behavior. So FW config needs to match kernel DT and vice versa. My FW config does not set any of these options, so I disabled the OOB interrupt in DT, too. Better option may be to upstream NVRAM config file to linux-firmware. But I don't think anyone has any idea which file is correct, and satisfies regulatory requirements. I guess adding muxenab=0x10 would fix this, since that's what Pinebook Pro uses and it has the same WiFi chip and similar design, and OOB interrupts work there. Best regards, o.
quoted hunk ↗ jump to hunk
Signed-off-by: Ondrej Jirman <megi@xff.cz> Signed-off-by: Rudraksha Gupta <redacted> --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 3 --- 1 file changed, 3 deletions(-)diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 97d0bf455258..69bb9de4ce55 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts@@ -834,9 +834,6 @@ &sdio0 { brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; - interrupt-parent = <&gpio4>; - interrupts = <RK_PD0 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; };-- 2.52.0