Re: [PATCH 2/3] mfd: rk8xx-core: Configure `rk808-clkout2` function
From: Lee Jones <lee@kernel.org>
Date: 2026-01-13 11:04:50
Also in:
linux-devicetree, linux-rockchip, lkml
On Mon, 12 Jan 2026, Rudraksha Gupta via B4 Relay wrote:
From: Kamil Trzciński <redacted> While the Wifi and Bluetooth chip are defined in the Pinephone Pro's DTS, it actually isn't able to be used. Let's define rk808-clkout2 so that userspace can actually interact with Wifi and Bluetooth Co-developed-by: Martijn Braam <redacted> Signed-off-by: Martijn Braam <redacted> Signed-off-by: Kamil Trzciński <redacted> Signed-off-by: Ondrej Jirman <megi@xff.cz> Signed-off-by: Rudraksha Gupta <redacted>
This is a bonkers amount of SoBs for a 3-line change. What on earth is going on here?
quoted hunk ↗ jump to hunk
--- drivers/mfd/rk8xx-core.c | 1 + include/linux/mfd/rk808.h | 2 ++ 2 files changed, 3 insertions(+)diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c index def4587fdfb8..602218694334 100644 --- a/drivers/mfd/rk8xx-core.c +++ b/drivers/mfd/rk8xx-core.c@@ -282,6 +282,7 @@ static const struct rk808_reg_data rk818_pre_init_reg[] = { { RK818_H5V_EN_REG, BIT(0), RK818_H5V_EN }, { RK808_VB_MON_REG, MASK_ALL, VB_LO_ACT | VB_LO_SEL_3500MV }, + { RK808_CLK32OUT_REG, CLK32KOUT2_FUNC_MASK, CLK32KOUT2_FUNC }, }; static const struct regmap_irq rk805_irqs[] = {diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h index 28170ee08898..077fe2e15b78 100644 --- a/include/linux/mfd/rk808.h +++ b/include/linux/mfd/rk808.h@@ -934,6 +934,8 @@ enum rk806_dvs_mode { #define VOUT_LO_INT BIT(0) #define CLK32KOUT2_EN BIT(0) +#define CLK32KOUT2_FUNC (0 << 1) +#define CLK32KOUT2_FUNC_MASK BIT(1) #define TEMP105C 0x08 #define TEMP115C 0x0c-- 2.52.0
-- Lee Jones [李琼斯]