Thread (10 messages) 10 messages, 2 authors, 2026-01-06

Re: 回复: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-01-06 07:47:26
Also in: linux-devicetree, lkml

On 06/01/2026 08:41, Gary Yang wrote:
Hi Krzysztof:

Thanks for you commets
quoted
EXTERNAL EMAIL

On 06/01/2026 05:52, Gary Yang wrote:
quoted
Hi Krzysztof:

Thanks for your comments
quoted
EXTERNAL EMAIL

On 05/01/2026 09:49, Gary Yang wrote:
quoted
Hi Krzysztof:

Thanks for your comments
quoted
EXTERNAL EMAIL

On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
quoted
OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core
64-bit processor + NPU processor,integrated graphics processor,
equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M
interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to
meet the needs of fast read/write and high-capacity storage

Signed-off-by: Gary Yang <redacted>
---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
b/Documentation/devicetree/bindings/arm/cix.yaml
index 114dab4bc4d2..9e132e609b7b 100644
--- a/Documentation/devicetree/bindings/arm/cix.yaml
+++ b/Documentation/devicetree/bindings/arm/cix.yaml
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:

-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus
Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to
you on the mailing list. Tools like b4 can help here. However,
there's no
need to repost patches *only* to add the tags.
quoted
quoted
The upstream maintainer will do that for tags received on the
version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/pro
ce
ss/sub
mitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Read last sentence and linked documentation. Where did you explain
ignoring/dropping my tag?
Yes, the previous version was acked by you before.
I stressed what I expect twice. In form letter and later explicitly.
You still ignored it.
quoted
When apply it, we found that orangepi 6 plus and Radxa Orion O6
belongs
the different boards.
quoted
So we need to add a new item for it. Like these from qcom.yaml

      - description: Qualcomm Technologies, Inc. Distributed Unit
1000
platform
quoted
        items:
          - enum:
              - qcom,qdu1000-idp
              - qcom,qdu1000-x100
          - const: qcom,qdu1000

      - description: Qualcomm Technologies, Inc. Radio Unit 1000
platform
quoted
quoted
quoted
        items:
          - enum:
              - qcom,qru1000-idp
          - const: qcom,qru1000
No, look at SoCs. Different SocS.
Please Look at rockchip.yaml, the same Socs, and the different boards

      - description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
        items:
          - const: vamrs,ficus
          - const: rockchip,rk3399

      - description: 96boards RK3399 Rock960 (ROCK960 Consumer
Edition)
quoted
        items:
          - const: vamrs,rock960
          - const: rockchip,rk3399

For the different boards,please give your professional
suggestions,Thanks a lot
I gave you already.
We find these codes below from qcom.yaml, Can we do the same things?
Open your binding. How many SKUs you have? ZERO.

Why do you ask if you can add more SKUs? To make the bindings fake? I
already told you what you have to do and you completely ignored it.
Previous code was correct, but you need to fix description. And look how
Qualcomm or IMX organizes this file.

I finished responding here, because you just don't bother to read my
replies.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help