Thread (3 messages) 3 messages, 3 authors, 2026-01-04

Re: [PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio dtsi for rk3506

From: Linus Walleij <linusw@kernel.org>
Date: 2026-01-04 12:07:13
Also in: linux-devicetree, linux-gpio, linux-rockchip, lkml

On Wed, Dec 31, 2025 at 9:18 AM Ye Zhang [off-list ref] wrote:
This file is auto-generated to provide a complete set of RMIO
configurations.   Our intention is to offer a generic library for all
future board developers, so they can simply pick the needed nodes by
phandle without manually looking up register values in the datasheet
every time.   This improves usability and standardization.
That makes it even more important to use the standard pinmux = <>;
property in pinmux-node.yaml for this instead of custom properties.

If you establish a standard, then use a standard.

We have two ways of doing pin control in DT:

1. Use strings for groups and functions.

    function = "uart";
    groups = "uart-tx-rx", "uart-cts-rts";

Since a lot of people really, really like to shoehorn a lot of information
into the device tree instead,

2. Use pinmux = <....>;

This is an opaque property that contains magic numbers. By using the
pinmux properties, developers and maintainers know that this is some
magic numbers that sets up the mux.

No custom invented properties please.

Historically old properties like rockchip,pins exist for the same purpose
of pinmux = <>; but this needs to stop and migrate to the standard
bindings, not proliferate.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help