On 27/12/2025 12:49, Ye Zhang wrote:

+		/omit-if-no-ref/
+		rm_io28_touch_key_in6: rm-io28-touch-key-in6 {
+			rockchip,pins =
+				<1 RK_PC3 7 &pcfg_pull_none>;
+			rockchip,rmio-pins =
+				<0 28 49>;
+		};
+
+		/omit-if-no-ref/
+		rm_io28_touch_key_in7: rm-io28-touch-key-in7 {
+			rockchip,pins =
+				<1 RK_PC3 7 &pcfg_pull_none>;
+			rockchip,rmio-pins =
+				<0 28 50>;
+		};
+
+		/omit-if-no-ref/
+		rm_io28_sai0_mclk: rm-io28-sai0-mclk {
+			rockchip,pins =
+				<1 RK_PC3 7 &pcfg_pull_none>;
+			rockchip,rmio-pins =
+				<0 28 51>;
+		};
+
+		/omit-if-no-ref/
+		rm_io28_sai0_sclk: rm-io28-sai0-sclk {
+			rockchip,pins =
+				<1 RK_PC3 7 &pcfg_pull_none>;
+			rockchip,rmio-pins =
+				<0 28 52>;
+		};
+
+		/omit-if-no-ref/
+		rm_io28_sai0_lrck: rm-io28-sai0-lrck {
+			rockchip,pins =
+				<1 RK_PC3 7 &pcfg_pull_none>;
+			rockchip,rmio-pins =
+				<0 28 53>;
+		};
+
+		/omit-if-no-ref/
+		rm_io28_sai0_sdi0: rm-io28-sai0-sdi0 {
+			rockchip,pins =
+				<1 RK_PC3 7 &pcfg_pull_none>;
+			rockchip,rmio-pins =
+				<0 28 54>;
+		};

Why are you defining all pins? This is wrong, your driver has to do it,
not DTS. All these definitions when not used are just pointless.


Best regards,
Krzysztof