Hi Krzysztof:

I'm glad to see your comments again.

-----邮件原件-----
发件人: Krzysztof Kozlowski [off-list ref]
发送时间: 2025年11月7日 15:18
收件人: Gary Yang [off-list ref]; p.zabel@pengutronix.de;
robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org
抄送: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; cix-kernel-upstream
[off-list ref]
主题: Re: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller

EXTERNAL EMAIL

On 07/11/2025 04:38, Gary Yang wrote:

quoted

+maintainers:
+  - Gary Yang [off-list ref]
+
+description: |
+  CIX Sky1 reset controller can be used to reset various set of peripherals.
+  There are two reset controllers, one is located in S0 domain, the other
+  is located in S5 domain.
+
+  See also:
+  - dt-bindings/reset/cix,sky1-rst.h

Use full path here.

OK, we will use full path: include/dt-bindings/reset/cix,sky1-rst.h

quoted

+
+properties:
+  compatible:
+    items:
+      - enum:
+          - cix,sky1-rst
+          - cix,sky1-rst-fch
+      - const: syscon
+
+  reg:
+    maxItems: 2

You need to list the items.

Sorry, to fix a build warning, make a mistake, we will fix it

quoted

+
+  '#reset-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#reset-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/reset/cix,sky1-rst.h>
+    reset-controller@16000000 {
+      compatible = "cix,sky1-rst", "syscon";
+      reg = <0x0 0x16000000 0x0 0x1000>;

Clearly wrong - you said two items.

We will use reg = <0x16000000 0x1000> to instead of it

quoted

+      #reset-cells = <1>;
+    };

...

quoted

+
+#define SKY1_FCH_RESET_NUM   29

Drop, not ABI (usually).

Ok, we will delete it

quoted

+
+#endif
+

...

quoted

+
+#define SKY1_RESET_NUM                               143

Drop

Ok, we will delete it

Best wishes
Gary

Best regards,
Krzysztof