Re: [PATCH 3/3] dts: reset: add support for cix sky1 resets
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-11-07 07:19:57
Also in:
linux-devicetree, lkml
On 07/11/2025 04:38, Gary Yang wrote:
There are two reset conctrollers on Cix Sky1 Soc. One is located in S0 domain, and the other is located in S5 domain. Signed-off-by: Gary Yang <gary.yang@cixtech.com> --- arch/arm64/boot/dts/cix/sky1.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Please start paying attention to this.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi index d21387224e79..fc68734f37c2 100644 --- a/arch/arm64/boot/dts/cix/sky1.dtsi +++ b/arch/arm64/boot/dts/cix/sky1.dtsi@@ -348,6 +348,13 @@ i3c1: i3c@4100000 { status = "disabled"; }; + src_fch: reset-controller@4160000 { + compatible = "cix,sky1-rst-fch", "syscon"; + reg = <0x0 0x04160000 0x0 0x90>; + #reset-cells = <1>; + status = "okay";
Why?
quoted hunk ↗ jump to hunk
+ }; + iomuxc: pinctrl@4170000 { compatible = "cix,sky1-iomuxc"; reg = <0x0 0x04170000 0x0 0x1000>;@@ -568,6 +575,13 @@ ppi_partition1: interrupt-partition-1 { }; }; + src: reset-controller@16000000 { + compatible = "cix,sky1-rst", "syscon"; + reg = <0x0 0x16000000 0x0 0x1000>; + #reset-cells = <1>; + status = "okay";
No, really, why? Best regards, Krzysztof