Thread (17 messages) 17 messages, 4 authors, 2025-11-10

Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-11-06 08:30:18
Also in: linux-amlogic, linux-devicetree, linux-pci, lkml

On Mon, Nov 03, 2025 at 03:42:58PM +0530, Manivannan Sadhasivam wrote:
On Mon, Nov 03, 2025 at 10:47:36AM +0100, Neil Armstrong wrote:
quoted
Hi Mani,

On 11/1/25 05:29, Manivannan Sadhasivam wrote:
quoted
Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must
have region for DWC controllers as it has the Root Port and controller
specific registers, while ELBI has optional registers.

Hence, fix the binding. Though this is an ABI break, this change is needed
to accurately describe the PCI memory map.
Not fan of this ABI break, the current bindings should be marked as deprecated instead.
Fair enough. Will make it as deprecated.
The true question is what value was being passed as that item (ELBI)?
Because if this was always DBI - device has DBI there - then what
deprecation would change?

Best regards,
Krzysztof

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help