On Mon, Nov 03, 2025 at 10:47:36AM +0100, Neil Armstrong wrote:

Hi Mani,

On 11/1/25 05:29, Manivannan Sadhasivam wrote:

quoted

Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must
have region for DWC controllers as it has the Root Port and controller
specific registers, while ELBI has optional registers.

Hence, fix the binding. Though this is an ABI break, this change is needed
to accurately describe the PCI memory map.

Not fan of this ABI break, the current bindings should be marked as deprecated instead.

Fair enough. Will make it as deprecated.

- Mani

quoted

Fixes: 7cd210391101 ("dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller")
Signed-off-by: Manivannan Sadhasivam <redacted>
---
  Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
index 79a21ba0f9fd62804ba95fe8a6cc3252cf652197..c8258ef4032834d87cf3160ffd1d93812801b62a 100644
--- a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml

@@ -36,13 +36,13 @@ properties:
    reg:
      items:
-      - description: External local bus interface registers
+      - description: Data Bus Interface registers
        - description: Meson designed configuration registers
        - description: PCIe configuration space
    reg-names:
      items:
-      - const: elbi
+      - const: dbi
        - const: cfg
        - const: config

@@ -113,7 +113,7 @@ examples:
      pcie: pcie@f9800000 {
          compatible = "amlogic,axg-pcie", "snps,dw-pcie";
          reg = <0xf9800000 0x400000>, <0xff646000 0x2000>, <0xf9f00000 0x100000>;
-        reg-names = "elbi", "cfg", "config";
+        reg-names = "dbi", "cfg", "config";
          interrupts = <GIC_SPI 177 IRQ_TYPE_EDGE_RISING>;
          clocks = <&pclk>, <&clk_port>, <&clk_phy>;
          clock-names = "pclk", "port", "general";

-- 
மணிவண்ணன் சதாசிவம்