Thread (29 messages) 29 messages, 4 authors, 2025-11-21

Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2025-10-24 08:40:42
Also in: linux-aspeed, linux-devicetree, linux-i2c, lkml, openbmc

Hi Krzysztof,
On 24/10/2025 09:56, Jeremy Kerr wrote:
quoted
Hi Krzysztof,
quoted
Although now I saw next patch, so clearly this commit is
incomplete.
The split that Ryan has done here - by shifting to an identical
separate
binding, then making the changes explicit - allows us to review the
actual changes without losing them in the move. Sounds like a
benefit to
me?
Not related. I commented that rationale is incomplete. We do not move
parts of bindings because new device is someway different. There are
hundreds of bindings which cover different devices. We move them
because the binding is different.
OK, but in that case I think we're after guidance on the threshold for
"difference" here.
Not much different than every other soc. All of them are separate IPs.
Look at any Samsung, NXP or Qualcomm binding. Separate IPs.
So, something like this?

    allOf:
      - $ref: /schemas/i2c/i2c-controller.yaml#
      - if:
          properties:
            compatible:
              contains:
                enum:
                  - aspeed,ast2600-i2c-bus
        then:
          required:
            - aspeed,global-regs


I can't see how we could represent aspeed,transfer-mode though, as it's
optional on aspeed,ast2600-i2c-bus, but prohibited on others. Any hints
on that?

Cheers,


Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help