Thread (29 messages) 29 messages, 4 authors, 2025-11-21

Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-10-24 06:45:24
Also in: linux-aspeed, linux-devicetree, linux-i2c, lkml, openbmc

On Tue, Oct 21, 2025 at 09:35:45AM +0800, Ryan Chen wrote:
The AST2600 I2C controller is a new hardware design compared to the
I2C controllers in previous ASPEED SoCs (e.g., AST2400, AST2500).

It introduces new features such as:
 - A redesigned register layout
 - Separation between controller and target mode registers
 - Transfer mode selection (byte, buffer, DMA)
 - Support for a shared global register block for configuration

Due to these fundamental differences, maintaining a separate
devicetree binding file for AST2600 helps to clearly distinguish
No, that's not a valid reason. You just moved the compatible and are
still 100% identical, at least according to this commit msg, so there is
no point in this patch.

NAK

Best regards,
Krzysztof

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help