Re: [PATCH 16/16] media: rockchip: rga: add rga3 support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-10-07 08:40:05
Also in:
linux-devicetree, linux-media, linux-rockchip, lkml
On 07/10/2025 17:32, Sven Püschel wrote:
Add support for the RGA3 unit contained in the RK3588. Only a basic feature set consisting of scaling and color conversion is implemented. Advanced features like rotation and cropping will just be ignored. Also the BT601F color space conversion is currently hard coded. The register address defines were copied from the vendor Rockchip kernel sources and slightly adjusted to not start at 0 again for the cmd registers. Signed-off-by: Sven Püschel <redacted> --- drivers/media/platform/rockchip/rga/Makefile | 2 +- drivers/media/platform/rockchip/rga/rga.c | 4 + drivers/media/platform/rockchip/rga/rga.h | 2 +- drivers/media/platform/rockchip/rga/rga3-hw.c | 490 ++++++++++++++++++++++++++ drivers/media/platform/rockchip/rga/rga3-hw.h | 186 ++++++++++ 5 files changed, 682 insertions(+), 2 deletions(-)
Your order of patches is a mess. DTS cannot be in the middle. In fact, DTS should not be even in this patchset, because you are targeting media. Best regards, Krzysztof