Re: [PATCH 03/10] dt-bindings: dma: Add RDA IFC DMA
From: Rob Herring <robh@kernel.org>
Date: 2025-09-22 18:07:25
Also in:
dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-hardening, linux-mmc, lkml
On Fri, Sep 19, 2025 at 01:48:43AM +0700, Dang Huynh wrote:
quoted hunk ↗ jump to hunk
The Intelligent Flow Controller (IFC) is a scatter/gather DMA controller. Signed-off-by: Dang Huynh <redacted> --- Documentation/devicetree/bindings/dma/rda,ifc.yaml | 45 ++++++++++++++++++++++ include/dt-bindings/dma/rda-ifc.h | 28 ++++++++++++++ 2 files changed, 73 insertions(+)diff --git a/Documentation/devicetree/bindings/dma/rda,ifc.yaml b/Documentation/devicetree/bindings/dma/rda,ifc.yaml new file mode 100644 index 0000000000000000000000000000000000000000..323e1e87cee09cfc7b64bf44bef61e4d1e91afa5 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/rda,ifc.yaml@@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/rda,ifc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RDA Intelligent Flow Controller (IFC) + +maintainers: + - Dang Huynh <dang.huynh@mainlining.org> + +description: |
Don't need '|'.
quoted hunk ↗ jump to hunk
+ RDA IFC is a DMA controller, it only supports scatter/gather lists. + +allOf: + - $ref: dma-controller.yaml# + +properties: + compatible: + items: + - enum: + - rda,8810pl-ifc + - const: rda,ifc + + reg: + maxItems: 1 + + "#dma-cells": + const: 1 + description: + The cell corresponding to DMA request ID + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + dma-controller@f0000 { + compatible = "rda,8810pl-ifc", "rda,ifc"; + reg = <0xf0000 0x1000>; + #dma-cells = <1>; + };diff --git a/include/dt-bindings/dma/rda-ifc.h b/include/dt-bindings/dma/rda-ifc.h new file mode 100644 index 0000000000000000000000000000000000000000..af4bae0542aa71690351e2406d0945a61eff72c1 --- /dev/null +++ b/include/dt-bindings/dma/rda-ifc.h@@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ + +#ifndef __DT_BINDINGS_DMA_RDA_IFC_H__ +#define __DT_BINDINGS_DMA_RDA_IFC_H__ + +#define IFC_UART1_TX 0 +#define IFC_UART1_RX 1 +#define IFC_UART2_TX 2 +#define IFC_UART2_RX 3 +#define IFC_SPI1_TX 4 +#define IFC_SPI1_RX 5 +#define IFC_SPI2_TX 6 +#define IFC_SPI2_RX 7 +#define IFC_SPI3_TX 8 +#define IFC_SPI3_RX 9 +#define IFC_SDMMC1_TX 10 +#define IFC_SDMMC1_RX 11 +#define IFC_SDMMC2_TX 12 +#define IFC_SDMMC2_RX 13 +#define IFC_SDMMC3_TX 14 +#define IFC_SDMMC3_RX 15 +#define IFC_NFSC_TX 16 +#define IFC_NFSC_RX 17 +#define IFC_UART3_TX 18 +#define IFC_UART3_RX 19 +#define IFC_NO_REQUEST 20
These numbers are defined by the h/w (like IRQ numbers)? If so, drop the header. We don't do headers for h/w numbers. Rob