Thread (22 messages) 22 messages, 6 authors, 2025-10-17

Re: [PATCH 06/10] gpio: rda: Make direction register unreadable

From: Bartosz Golaszewski <hidden>
Date: 2025-09-22 14:21:03
Also in: dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-hardening, linux-mmc, lkml

On Thu, Sep 18, 2025 at 8:49 PM Dang Huynh via B4 Relay
[off-list ref] wrote:
From: Dang Huynh <redacted>

The register doesn't like to be read and would cause all the input
to be switched to output.

This causes the SD Card Detect GPIO to misbehaves in the OS and/or
may cause hardware to malfunction.

Signed-off-by: Dang Huynh <redacted>
---
I have responded to you already[1]. The commit message is still
sub-par. Don't say "the register doesn't like", say: "Reading the X
register causes Y to happen. In order to remedy it, do Z." You haven't
answered my question: what will happen to existing users of this
driver?

Also: you have not bumped the series version to v2, that makes
tracking the changes hard.

Bartosz

[1] https://lore.kernel.org/all/CAMRc=MeHQf_Oa2DRR0T7tum-Tuk3qPh5r5gimxGY3EXTyvoKZQ@mail.gmail.com/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help