RE: [EXT] Re: [PATCH v2 0/5] media: imx91: Add ISI support

Hi Laurent,

Many thanks for you reviews.

-----Original Message-----
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sent: Monday, September 22, 2025 6:31 AM
To: Frank Li <frank.li@nxp.com>
Cc: G.N. Zhou <redacted>; Mauro Carvalho Chehab
[off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Conor Dooley [off-list ref]; Shawn Guo
[off-list ref]; Sascha Hauer [off-list ref];
Pengutronix Kernel Team [off-list ref]; Fabio Estevam
[off-list ref]; linux-media@vger.kernel.org;
devicetree@vger.kernel.org; imx@lists.linux.dev; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Alice Yuan
[off-list ref]; Krzysztof Kozlowski [off-list ref]
Subject: [EXT] Re: [PATCH v2 0/5] media: imx91: Add ISI support

Caution: This is an external email. Please take care when clicking links or
opening attachments. When in doubt, report the message using the 'Report this
email' button


On Sun, Sep 21, 2025 at 07:07:06PM +0300, Laurent Pinchart wrote:

quoted

On Fri, Sep 19, 2025 at 12:11:38PM -0400, Frank Li wrote:

quoted

On Fri, Sep 19, 2025 at 02:40:01AM +0000, G.N. Zhou wrote:

quoted

Hi,

Could you help to please review the patches which I have submitted
some time back to linux media community and move forward driver
part if possible.

Your feedback will be very appreciated. Thanks.

Best Regards
G.N Zhou

Laurent Pinchart:

    Could you please consider pickup these patches? Consider these
related simple changes, is my Reviewed-by enough?

I've completed a set of other reviews and will get to this patch
series in the upcoming week.

There's just an open question on 2/5. It's about the commit message, so it
shouldn't be a big deal. Once I get a reply to that, I can apply the series with the
small proposed changes, there's no need to submit a v3, unless you prefer
doing so.

I'm very happy to follow your advices and apply on your side as you said. Thank you very much.

quoted

quoted

quoted

quoted

Add ISI support for i.MX91 chip.

The bellow patch refine code, no functions changed.
   media: nxp: imx8-isi: Simplify code by using helper macro
   media: nxp: imx8-isi: Reorder the platform data

The bindings and driver patch for i.MX91 ISI.
   media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string
   media: nxp: imx8-isi: Add ISI support for i.MX91

Add parallel camera input for i.MX93 ISI.
   media: nxp: imx8-isi: Add parallel camera input support

Signed-off-by: Guoniu Zhou <redacted>
---
Changes in v2:
- Update commit log in patch 5 to better describe why introduce it.
- Include two header files in patch 2 since kernel test robot report build
  issue when arch is riscv and compiler is clang-22.
  #include <linux/bitfield.h>
  #include <linux/bits.h>
- Link to v1:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%
2Flore.kernel.org%2Fall%2F20250827-isi_imx93-v1-0-

&data=05%7C02%

quoted

quoted

quoted

quoted

7Cguoniu.zhou%40nxp.com%7C160464d861a24abf246e08ddf95e93bd%7C68
6

quoted

quoted

quoted

quoted

ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638940906787985916%7C
Unk

quoted

quoted

quoted

quoted

nown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCI
sI

quoted

quoted

quoted

quoted

lAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sda

quoted

quoted

quoted

quoted

ta=MJUx0UV12LxPISHvimNpvs6Sfc8qxXr4Yrrix2N8%2BF8%3D&reserved=0

quoted

quoted

quoted

quoted

83e6b4b50c4d@nxp.com

---
Alice Yuan (2):
      media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string
      media: nxp: imx8-isi: Add parallel camera input support

Guoniu Zhou (3):
      media: nxp: imx8-isi: Simplify code by using helper macro
      media: nxp: imx8-isi: Reorder the platform data
      media: nxp: imx8-isi: Add ISI support for i.MX91

 .../devicetree/bindings/media/nxp,imx8-isi.yaml    | 13 +++++-
 .../media/platform/nxp/imx8-isi/imx8-isi-core.c    | 50

++++++++++++++--------

quoted

quoted

quoted

quoted

 .../media/platform/nxp/imx8-isi/imx8-isi-core.h    |  1 +
 .../media/platform/nxp/imx8-isi/imx8-isi-gasket.c  | 18
++++++--
 4 files changed, 59 insertions(+), 23 deletions(-)
---
base-commit: 603957ae903e81fb80d3788297c0f58a68802dfc
change-id: 20250826-isi_imx93-4a59288b33e4

--
Regards,

Laurent Pinchart