Re: [PATCH v2 0/5] media: imx91: Add ISI support

On Sun, Sep 21, 2025 at 07:07:06PM +0300, Laurent Pinchart wrote:

On Fri, Sep 19, 2025 at 12:11:38PM -0400, Frank Li wrote:

quoted

On Fri, Sep 19, 2025 at 02:40:01AM +0000, G.N. Zhou wrote:

quoted

Hi,

Could you help to please review the patches which I have submitted
some time back to linux media community and move forward driver part
if possible.

Your feedback will be very appreciated. Thanks.

Best Regards
G.N Zhou

Laurent Pinchart:

	Could you please consider pickup these patches? Consider these
related simple changes, is my Reviewed-by enough?

I've completed a set of other reviews and will get to this patch series
in the upcoming week.

There's just an open question on 2/5. It's about the commit message, so
it shouldn't be a big deal. Once I get a reply to that, I can apply the
series with the small proposed changes, there's no need to submit a v3,
unless you prefer doing so.

quoted

quoted

quoted

Add ISI support for i.MX91 chip.

The bellow patch refine code, no functions changed.
   media: nxp: imx8-isi: Simplify code by using helper macro
   media: nxp: imx8-isi: Reorder the platform data

The bindings and driver patch for i.MX91 ISI.
   media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string
   media: nxp: imx8-isi: Add ISI support for i.MX91

Add parallel camera input for i.MX93 ISI.
   media: nxp: imx8-isi: Add parallel camera input support

Signed-off-by: Guoniu Zhou <redacted>
---
Changes in v2:
- Update commit log in patch 5 to better describe why introduce it.
- Include two header files in patch 2 since kernel test robot report build
  issue when arch is riscv and compiler is clang-22.
  #include <linux/bitfield.h>
  #include <linux/bits.h>
- Link to v1: https://lore.kernel.org/all/20250827-isi_imx93-v1-0-
83e6b4b50c4d@nxp.com

---
Alice Yuan (2):
      media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string
      media: nxp: imx8-isi: Add parallel camera input support

Guoniu Zhou (3):
      media: nxp: imx8-isi: Simplify code by using helper macro
      media: nxp: imx8-isi: Reorder the platform data
      media: nxp: imx8-isi: Add ISI support for i.MX91

 .../devicetree/bindings/media/nxp,imx8-isi.yaml    | 13 +++++-
 .../media/platform/nxp/imx8-isi/imx8-isi-core.c    | 50 ++++++++++++++--------
 .../media/platform/nxp/imx8-isi/imx8-isi-core.h    |  1 +
 .../media/platform/nxp/imx8-isi/imx8-isi-gasket.c  | 18 ++++++--
 4 files changed, 59 insertions(+), 23 deletions(-)
---
base-commit: 603957ae903e81fb80d3788297c0f58a68802dfc
change-id: 20250826-isi_imx93-4a59288b33e4

-- 
Regards,

Laurent Pinchart