Re: [PATCH 22/25] mmc: host: Add RDA Micro SD/MMC driver
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-09-17 00:48:13
Also in:
dmaengine, linux-clk, linux-devicetree, linux-gpio, linux-hardening, linux-mmc, linux-pm, linux-rtc, lkml
On 17/09/2025 22:25, Dang Huynh via B4 Relay wrote:
quoted hunk ↗ jump to hunk
From: Dang Huynh <redacted> RDA Micro RDA8810PL includes an SD/MMC controller. This controller supports SD/SDIO/MMC interface. Signed-off-by: Dang Huynh <redacted> --- MAINTAINERS | 6 + drivers/mmc/host/Kconfig | 12 + drivers/mmc/host/Makefile | 1 + drivers/mmc/host/rda-mmc.c | 853 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 872 insertions(+)diff --git a/MAINTAINERS b/MAINTAINERS index 91be43782f4ba8aacb629002d357a66704f10b2b..33e04ce35dcc4cbadd715ec9199f2453237b8002 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -21417,6 +21417,12 @@ S: Maintained F: Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml F: drivers/rtc/rtc-rda.c +RDA MICRO SECURE DIGITAL AND MULTIMEDIA CARD DRIVER +M: Dang Huynh <dang.huynh@mainlining.org> +S: Maintained +F: Documentation/devicetree/bindings/mmc/rda,mmc.yaml +F: drivers/mmc/host/rda-mmc.c + RDACM20 Camera Sensor M: Jacopo Mondi <jacopo+renesas@jmondi.org> M: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 4afa0130779d97ca9d1c0ed2102b0babdedcaeeb..352a6eb4e30793b7311c7877c238a7fe31121123 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig@@ -1040,6 +1040,18 @@ config MMC_MTK This is needed if support for any SD/SDIO/MMC devices is required. If unsure, say N. +config MMC_RDA + tristate "RDA Micro SD/MMC Card Interface support" + depends on ARCH_RDA
Missing compile test
+ depends on COMMON_CLK + depends on HAS_DMA + help + This selects the RDA Micro Secure digital and Multimedia card interface. The + controller supports SD/SDIO/MMC interface. + If you have a board with RDA SoC and it uses this interface, say Y or M here. + + If unsure, say N.
...
+};
+MODULE_DEVICE_TABLE(of, rda_mmc_dt_ids);
+
+static struct platform_driver rda_mmc_driver = {
+ .probe = rda_mmc_probe,
+ .remove = rda_mmc_remove,
+ .driver = {
+ .name = "rda-mmc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
+ .of_match_table = rda_mmc_dt_ids,
+ },
+};
+module_platform_driver(rda_mmc_driver);
+
+MODULE_AUTHOR("Dang Huynh [off-list ref]");
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("MMC/SD driver for RDA platform");
+MODULE_ALIAS("platform:rda-mmc");You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong (e.g. misses either entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete ID table.
Best regards, Krzysztof