Re: [PATCH v2 12/22] usb: typec: tipd: Update partner identity when power status was updated
From: Sven Peter <sven@kernel.org>
Date: 2025-09-07 18:59:36
Also in:
asahi, linux-devicetree, linux-phy, linux-usb, lkml
On 07.09.25 10:54, Sergey Shtylyov wrote:
On 9/6/25 6:43 PM, Sven Peter wrote:quoted
From: Hector Martin <redacted> Whenever the power status is changed make sure to also update the partner identity to be able to detect changes once de-bouncing and mode changes are added for CD321x. Signed-off-by: Hector Martin <redacted> Signed-off-by: Sven Peter <sven@kernel.org> --- drivers/usb/typec/tipd/core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index c7cf936e5a61a331271c05b68ff1b77b89c0f643..cd427eecd8a594b7e609a20de27a9722055307d8 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c@@ -635,9 +635,16 @@ static irqreturn_t cd321x_interrupt(int irq, void *data) if (!tps6598x_read_status(tps, &status)) goto err_unlock; - if (event & APPLE_CD_REG_INT_POWER_STATUS_UPDATE) + if (event & APPLE_CD_REG_INT_POWER_STATUS_UPDATE) { if (!tps6598x_read_power_status(tps)) goto err_unlock; + if (TPS_POWER_STATUS_PWROPMODE(tps->pwr_status) == TYPEC_PWR_MODE_PD) { + if (tps6598x_read_partner_identity(tps)) { + dev_err(tps->dev, "failed to partner identity\n");Perhaps "failed to read partner identity\n"?
Yup, good catch! Thanks, Sven