Re: [PATCH v2 18/22] phy: apple: Add Apple Type-C PHY
From: Alyssa Anne Rosenzweig <hidden>
Date: 2025-09-07 13:15:40
Also in:
asahi, linux-devicetree, linux-phy, linux-usb, lkml
In functions like atcphy_dp_configure_lane, I'm wondering if we want to pull out individual registers like `void __iomem *tx_shm_txa_ldoclk = tx_shm + LN_AUSPMA_TX_SHM_TXA_LDOCLK`, likewise for MAIN_REG0/1/IMP_REG0/etc, just to make the actual pokes below a lot less noisy. Incidentally, the txa_ldoclk_bypass handling is another place where the cond_set32 helper would shine. --- Also, do we know what _OV means?