Re: [PATCH v3 3/3] arm64: dts: ti: k3-pinctrl: Add the remaining macros

Hi Sebin,

On 04/09/25 11:32, Sebin Francis wrote:

Hi Akash,

On 02/09/25 12:49, Akashdeep Kaur wrote:

quoted

Add the drive stregth, schmitt trigger enable macros to pinctrl file.
Add the missing macros for DeepSleep configuration control referenced
from "Table 14-6172. Description Of The Pad Configuration Register Bits"
in AM625 TRM[0].
Add some DeepSleep macros to provide combinations that can be used
directly in device tree files example PIN_DS_OUTPUT_LOW that
configures pin to be output and also sets its value to 0.

[0] https://www.ti.com/lit/ug/spruiv7b/spruiv7b.pdf

Signed-off-by: Akashdeep Kaur <redacted>

...

quoted

+#define WKUP_ON_EDGE            (0 << WKUP_LVL_EN_SHIFT)
+#define WKUP_LEVEL_LOW          (0 << WKUP_LVL_POL_SHIFT)
+#define WKUP_LEVEL_HIGH         (1 << WKUP_LVL_POL_SHIFT)
+
+#define WKUP_DISABLE            (0 << WKUP_EN_SHIFT)

This can be moved below WKUP_ENABLE macro to be consistent

Moved. Thanks

quoted

+
  /* Only these macros are expected be used directly in device tree 
files */
  #define PIN_OUTPUT        (INPUT_DISABLE | PULL_DISABLE)
  #define PIN_OUTPUT_PULLUP    (INPUT_DISABLE | PULL_UP)

...

...

quoted

+#define DS_STATE_VAL                    (1 << DS_EN_SHIFT)
+#define ACTIVE_STATE_VAL                (0 << DS_EN_SHIFT)

These can be moved to the top before PIN_* and can be renamed to 
DS_STATE_EN and DS_STATE_DIS

Moved and renamed.>> +

quoted

+#define PIN_DS_OUTPUT_LOW               (DS_STATE_VAL | 
DS_INPUT_DISABLE | DS_OUT_VALUE_ZERO)

...

quoted

+#define PIN_WKUP_EN_LEVEL_HIGH          (WKUP_ENABLE | WKUP_ON_LEVEL 
| WKUP_LEVEL_HIGH)
+#define PIN_WKUP_EN                     WKUP_EN_EDGE

As EDGE wake is used commonly we can use the PIN_WKUP_EN_EDGE in this case

That's a good idea. Changed.

quoted

  /* Default mux configuration for gpio-ranges to use with pinctrl */
  #define PIN_GPIO_RANGE_IOPAD    (PIN_INPUT | 7)

Thanks
Sebin

Regards,
Akashdeep Kaur