Re: [PATCH 02/14] dmaengine: dma350: Add missing dch->coherent setting
From: Robin Murphy <robin.murphy@arm.com>
Date: 2025-08-29 10:52:57
Also in:
dmaengine, linux-devicetree, lkml
On 2025-08-23 4:39 pm, Jisheng Zhang wrote:
quoted hunk ↗ jump to hunk
The dch->coherent setting is missing. Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- drivers/dma/arm-dma350.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/dma/arm-dma350.c b/drivers/dma/arm-dma350.c index bf3962f00650..24cbadc5f076 100644 --- a/drivers/dma/arm-dma350.c +++ b/drivers/dma/arm-dma350.c@@ -587,6 +587,7 @@ static int d350_probe(struct platform_device *pdev) for (int i = 0; i < nchan; i++) { struct d350_chan *dch = &dmac->channels[i]; + dch->coherent = coherent;
Nit: I'd put this a bit further down with the CH_LINKATTR setup, but otherwise, Reviewed-by: Robin Murphy <robin.murphy@arm.com>
dch->base = base + DMACH(i); writel_relaxed(CH_CMD_CLEAR, dch->base + CH_CMD);