Thread (35 messages) 35 messages, 5 authors, 2025-09-01

Re: [PATCH 01/14] dmaengine: dma350: Fix CH_CTRL_USESRCTRIGIN definition

From: Robin Murphy <robin.murphy@arm.com>
Date: 2025-08-29 10:44:28
Also in: dmaengine, linux-devicetree, lkml

On 2025-08-23 4:39 pm, Jisheng Zhang wrote:
Per the arm-dma350 TRM, The CH_CTRL_USESRCTRIGIN is BIT(25).
Oops!

Reviewed-by: Robin Murphy <robin.murphy@arm.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
  drivers/dma/arm-dma350.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/arm-dma350.c b/drivers/dma/arm-dma350.c
index 9efe2ca7d5ec..bf3962f00650 100644
--- a/drivers/dma/arm-dma350.c
+++ b/drivers/dma/arm-dma350.c
@@ -58,7 +58,7 @@
  
  #define CH_CTRL			0x0c
  #define CH_CTRL_USEDESTRIGIN	BIT(26)
-#define CH_CTRL_USESRCTRIGIN	BIT(26)
+#define CH_CTRL_USESRCTRIGIN	BIT(25)
  #define CH_CTRL_DONETYPE	GENMASK(23, 21)
  #define CH_CTRL_REGRELOADTYPE	GENMASK(20, 18)
  #define CH_CTRL_XTYPE		GENMASK(11, 9)
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help