Re: [PATCH v2 6/6] firmware: imx: sm-misc: Dump syslog info
From: Cristian Marussi <cristian.marussi@arm.com>
Date: 2025-08-19 17:28:21
Also in:
arm-scmi, imx, lkml
On Thu, Jul 10, 2025 at 04:33:31PM +0800, Peng Fan wrote:
quoted hunk ↗ jump to hunk
Add sysfs interface to read System Manager syslog info Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/firmware/imx/sm-misc.c | 178 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 178 insertions(+)diff --git a/drivers/firmware/imx/sm-misc.c b/drivers/firmware/imx/sm-misc.c index fc3ee12c2be878e0285183e3381c9514a63d5142..10aab5b127f65ecc57db9ab6c0c2c2b84d1dd864 100644 --- a/drivers/firmware/imx/sm-misc.c +++ b/drivers/firmware/imx/sm-misc.c@@ -3,6 +3,7 @@ * Copyright 2024 NXP */
Hi, I have not so much to say about this: you expose one value per-sysfs entry as prescribe BUT this also means a lot of messages to exchage to retrieve a whole new fresh log each time a single sysfs entry is queried...a bit ugly but I wouldn't now how to handle this differently with the current log command format indeed... Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian