Re: [PATCH v2 4/6] firmware: arm_scmi: imx: Support getting board info of MISC protocol
From: Cristian Marussi <cristian.marussi@arm.com>
Date: 2025-08-19 16:28:28
Also in:
arm-scmi, imx, lkml
On Thu, Jul 10, 2025 at 04:33:29PM +0800, Peng Fan wrote:
quoted hunk ↗ jump to hunk
MISC protocol supports getting board information. Retrieve the information from SM. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+)diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c index dc6ea67255b8b1ac95dfb552fa88b65044de8d3f..6b86c35c192d02e13f0d2a7d713bc447886b84bf 100644 --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c@@ -27,6 +27,7 @@ enum scmi_imx_misc_protocol_cmd { SCMI_IMX_MISC_CTRL_GET = 0x4, SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6, SCMI_IMX_MISC_CFG_INFO = 0xC, + SCMI_IMX_MISC_BOARD_INFO = 0xE, SCMI_IMX_MISC_CTRL_NOTIFY = 0x8, };@@ -76,6 +77,12 @@ struct scmi_imx_misc_buildinfo_out { u8 buildtime[MISC_MAX_BUILDTIME]; }; +struct scmi_imx_misc_board_info_out { + __le32 attributes; +#define MISC_MAX_BRDNAME 16 + u8 brdname[MISC_MAX_BRDNAME]; +}; + struct scmi_imx_misc_cfg_info_out { __le32 msel; #define MISC_MAX_CFGNAME 16@@ -317,6 +324,30 @@ static int scmi_imx_misc_discover_build_info(const struct scmi_protocol_handle * return ret; } +static int scmi_imx_misc_board_info(const struct scmi_protocol_handle *ph) +{ + struct scmi_imx_misc_board_info_out *out; + char name[MISC_MAX_BRDNAME] = {'\0'};
same...
+ struct scmi_xfer *t;
+ int ret;
+
+ ret = ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_BOARD_INFO, 0, sizeof(*out), &t);
+ if (ret)
+ return ret;
+
+ ret = ph->xops->do_xfer(ph, t);
+ if (!ret) {
+ out = t->rx.buf;
+ strscpy(name, out->brdname, MISC_MAX_BRDNAME);
+ dev_info(ph->dev, "Board\t\t= %s, attr=0x%08x\n",
+ name, le32_to_cpu(out->attributes));
+ }
+...other than this...LGTM. Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian