On Mon, 2025-08-11 at 13:02 +0200, Krzysztof Kozlowski wrote:

External email : Please do not click links or open attachments until
you have verified the sender or the content.


On 11/08/2025 10:15, ot_shunxi.zhang@mediatek.com wrote:

quoted

From: Shunxi Zhang <redacted>

This patch adds new bit definitions for the RTC_BBPU register in
the

Why? There is no user of these. Don't add useless defines.

quoted

mt6397 RTC header file. The following bit definitions are
introduced:

Hm?

quoted

Signed-off-by: Shunxi Zhang <redacted>
---
 include/linux/mfd/mt6397/rtc.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/linux/mfd/mt6397/rtc.h

b/include/linux/mfd/mt6397/rtc.h
index 27883af44f87..001cef6b7302 100644

--- a/include/linux/mfd/mt6397/rtc.h
+++ b/include/linux/mfd/mt6397/rtc.h

@@ -15,8 +15,11 @@
 #include <linux/rtc.h>

 #define RTC_BBPU               0x0000
+#define RTC_BBPU_PWREN         BIT(0)
+#define RTC_BBPU_CLR           BIT(1)
+#define RTC_BBPU_RESET_AL      BIT(3)
 #define RTC_BBPU_CBUSY         BIT(6)
-#define RTC_BBPU_KEY            (0x43 << 8)
+#define RTC_BBPU_KEY           (0x43 << 8)

Why?



Best regards,
Krzysztof

Dear sir,
The MT6397 is an integration of several ICs and does not have a
separate IC specification. I will check the relevant IC datasheets
again. I will remove the useless define in next version.

Thanks for your commnets.

Best regards
Shunxi Zhangus