On 23/07/2025 23:58, Donald Shannon wrote:

On 7/22/25 22:56, Krzysztof Kozlowski wrote:

quoted

External email: Use caution opening links or attachments


On 23/07/2025 03:42, Donald Shannon wrote:

quoted

This is an Aspeed AST2600 based unit testing platform for GB200.
UT3.0b is different than nvidia-gb200nvl-bmc due to networking topology
differences, additional gpio expanders, and voltage regulator gating
some devices.

Reference to Ast2600 SOC [1].
Reference to Blackwell GB200NVL Platform [2].

Link: https://www.aspeedtech.com/server_ast2600/ [1]
Link: https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2]
Signed-off-by: Donald Shannon <redacted>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Why are you faking tags? No, you cannot just add whatever you want.

Best regards,
Krzysztof

Hi Krzysztof,

I think I was confused by your message on my V5 patch. I will remove the Acked-by and resubmit:

quoted

A nit, subject: drop second/last, redundant "binding". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

With above two:

Acked-by: Krzysztof Kozlowski <redacted>

And what did you paste in your patch?

And why?


Best regards,
Krzysztof