RE: [PATCH v3 2/2] irqchip: aspeed: add debugfs support and AST2700 INTC0/INTC1 routing/protection display

Subject: RE: [PATCH v3 2/2] irqchip: aspeed: add debugfs support and AST2700
INTC0/INTC1 routing/protection display

On Wed, Jul 23 2025 at 06:02, Ryan Chen wrote:

quoted

quoted

quoted

+struct aspeed_intc {
+	void __iomem *base;
+	struct device *dev;
+	struct dentry *dbg_root;
+	int (*show_routing)(struct seq_file *s, void *unused);
+	int (*show_prot)(struct seq_file *s, void *unused); };

See the chapter about struct declarations and initializers in the
documentation I linked to above.

Sorry, I don't see the struct "> > +	int (*show_prot)(struct seq_file *s, void

*unused); };"

I fatfingered that, but that's not the problem.

quoted

My original submit is following, it should ok. Am I right?

No. Read the chapter I pointed you to.

quoted

https://www.spinics.net/lists/kernel/msg5776957.html

Thanks, I think your point is align the struct member names.
Will update.
struct aspeed_intc {
        void __iomem		*base;
        struct device		*dev;
        struct dentry		*dbg_root;
        int				(*show_routing)(struct seq_file *s, void *unused);
        int				(*show_prot)(struct seq_file *s, void *unused);
};

I have replied to this very mail. No need to paste me this and the pointer to
some random mail archive