Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

On Thu, 2025-06-12 at 17:16 +0200, Krzysztof Kozlowski wrote:

External email : Please do not click links or open attachments until
you have verified the sender or the content.


On 21/05/2025 08:33, Friday Yang wrote:

quoted

From: "Friday Yang" <redacted>

To prevent handling glitch signals during MTCMOS on/off
transitions,
SMI requires clamp and reset operations. Parse the reset settings
for
SMI LARBs and the clamp settings for the SMI Sub-Common. Register
genpd callback for the SMI LARBs located in image, camera and IPE
subsystems, and apply reset and clamp operations within the
callback.

Signed-off-by: Friday Yang <redacted>
Reviewed-by: AngeloGioacchino Del Regno <
angelogioacchino.delregno@collabora.com>
Acked-by: Rob Herring <robh@kernel.org>

You did not respond to previous review. Sending the same while
ignoring
previous review is obvious NAK.

Apologies for missing the message. In the v6 patch, I replaced
'pm_runtime_enable' with 'devm_pm_runtime_enable'. You pointed out that
this change might alter the cleanup order and potentially introduce
errors.

v6:
https://lore.kernel.org/lkml/20250408033206.12176-3-friday.yang@mediatek.com/ (local)

Therefore, in the v7 patch, I reverted this change and continued using
'pm_runtime_enable' in the SMI driver. However, I did not include a
clear description of the changes between v6 and v7 in the cover letter.

v7:
https://lore.kernel.org/lkml/9f01a9a4-89b2-4bfc-97cd-827be989ef16@kernel.org/ (local)

In the v8 patch, I have added a description in the cover letter.
This series just add functions for SMI clamp and not change anything
else. Is this acceptable to you?

Best regards,
Krzysztof