Thread (25 messages) 25 messages, 4 authors, 2025-07-24

Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-07-17 11:29:05
Also in: linux-devicetree, linux-phy, linux-samsung-soc, lkml

On 17/07/2025 13:13, Pritam Manohar Sutar wrote:
quoted

Nothing is explained in changelog/cover letter. You claim you only added Rb tag.
This is an entirely silent change while keeping the review.
Will add more explanations in cover letter/changelog why this block is added.
quoted
Combined with not even following DTS style!
Ok got it. Will change supplies name as below 
avdd075_usb => avdd075-usb
avdd18_usb20 => avdd18-usb20
avdd33_usb20 => avdd33-usb20
   
Confirm the above change that is meant in terms of DTS style.
Yes. I have doubts that actual supplies have suffix usb20. Are there
more than one avdd18 for this block?

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help