Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
From: Krzysztof Kozlowski <hidden>
Date: 2025-07-06 09:40:39
Also in:
linux-devicetree, linux-phy, linux-samsung-soc, lkml
On Tue, Jul 01, 2025 at 05:37:01PM +0530, Pritam Manohar Sutar wrote:
Add a dedicated compatible string for USB HS phy found in this SoC. The SoC requires two clocks, named "phy" and "ref" (same as clocks required by Exynos850). It also requires various power supplies (regulators) for the internal circuitry to work. The required voltages are: * avdd075_usb - 0.75v * avdd18_usb20 - 1.8v * avdd33_usb20 - 3.3v Reviewed-by: Krzysztof Kozlowski <redacted>
No, really. Look:
quoted hunk ↗ jump to hunk
Signed-off-by: Pritam Manohar Sutar <redacted> --- .../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+)diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml index e906403208c0..2e29ff749bba 100644 --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml@@ -34,6 +34,7 @@ properties: - samsung,exynos7870-usbdrd-phy - samsung,exynos850-usbdrd-phy - samsung,exynos990-usbdrd-phy + - samsung,exynosautov920-usbdrd-phy clocks: minItems: 1@@ -110,6 +111,15 @@ properties: vddh-usbdp-supply: description: VDDh power supply for the USB DP phy. + avdd075_usb-supply: + description: 0.75V power supply for USB phy + + avdd18_usb20-supply: + description: 1.8V power supply for USB phy + + avdd33_usb20-supply: + description: 3.3V power supply for USB phy +
None of these were here. Follow DTS coding style... but why are you adding completely new supplies?
quoted hunk ↗ jump to hunk
required: - compatible - clocks@@ -235,6 +245,33 @@ allOf: reg-names: maxItems: 1 + - if: + properties: + compatible: + contains: + enum: + - samsung,exynosautov920-usbdrd-phy + then: + properties: + clocks: + minItems: 2 + maxItems: 2 + + clock-names: + items: + - const: phy + - const: ref + + reg: + maxItems: 1 + + reg-names: + maxItems: 1 + + required: + - avdd075_usb-supply + - avdd18_usb20-supply + - avdd33_usb20-supply
Neither was this entire diff hunk here. This was part of other block for a reason. NAK Best regards, Krzysztof