Thread (23 messages) 23 messages, 3 authors, 2025-07-17

Re: [PATCH v2 06/13] PCI: xgene-msi: Drop superfluous fields from xgene_msi structure

From: Markus Elfring <hidden>
Date: 2025-07-17 11:25:26
Also in: linux-pci, lkml

quoted hunk ↗ jump to hunk
+++ b/drivers/pci/controller/pci-xgene-msi.c
quoted hunk ↗ jump to hunk
@@ -214,7 +212,7 @@ static void xgene_irq_domain_free(struct irq_domain *domain,
 	mutex_lock(&msi->bitmap_lock);
 
 	hwirq = hwirq_to_canonical_hwirq(d->hwirq);
-	bitmap_clear(msi->bitmap, hwirq, msi->num_cpus);
+	bitmap_clear(msi->bitmap, hwirq, num_possible_cpus());
 
 	mutex_unlock(&msi->bitmap_lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&msi->bitmap_lock);”?
https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help